Add extra checks when installing Rust - display some warning messages, if needed #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popenta
reviewed
Nov 27, 2023
| @@ -273,10 +273,13 @@ def is_installed(self, tag: str) -> bool: | |||
| return all(dependency is not None for dependency in dependencies) | |||
|
|
|||
| def install(self, overwrite: bool) -> None: | |||
| self._check_install_env() | |||
There was a problem hiding this comment.
I think that if someone uses the --overwrite flag, the existing CARGO_HOME and RUSTUP_HOME should reset to the default location, as if rust was not previously installed.
There was a problem hiding this comment.
Indeed, we should do that 🙌
popenta
approved these changes
Nov 27, 2023
ovidiuolteanu
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display WARN messages if
CARGO_HOMEandRUSTUP_HOMEare set before the installation:https://rust-lang.github.io/rustup/installation/index.html#choosing-where-to-install
Unset the variables if installing rust with
--overwrite.