Contract templates and contract new from template using sc-meta #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sub.add_argument("--template", required=True, help="the template to use") | ||
| sub.add_argument("--directory", type=str, default=os.getcwd(), | ||
| help="🗀 the parent directory of the project (default: current directory)") | ||
| sub.add_argument("--tag", help="the framework version on which the contract should be created") |
There was a problem hiding this comment.
maybe specify the version that will be used in case that the flag is not set
There was a problem hiding this comment.
That version is somehow out of mxpy's control.
There was a problem hiding this comment.
Indeed. I was trying to figure out if there is a simple way to do that, but I think it's to much work for what it adds.
| sub.set_defaults(func=create) | ||
|
|
||
| sub = cli_shared.add_command_subparser(subparsers, "contract", "templates", | ||
| "List the available Smart Contract templates.") | ||
| sub.add_argument("--tag", help="the sc-meta framework version referred to") |
There was a problem hiding this comment.
specify the default value
andreibancioiu
approved these changes
Oct 3, 2023
bogdan-rosianu
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on,
mxpywill usesc-metafor displaying the available contract templates and for creating a new contract using the available templates.This PR contains a few breaking changes:
For the
mxpy contract newcommand:nameargument is no longer a positional argument, should be used as a keyword argument:--name--directoryargument is no longer existent,--pathshould be used instead--tag. It is used to specify the framework version on which the contract should be createdFor the
mxpy templatescommand:--tagargument has been added. It is used to specify thesc-metaframework version referred to