fix skip_on_windows marker

.github/workflows/build-windows.yml

@@ -47,7 +47,7 @@ jobs:
         shell: bash
         run: |
           export PYTHONPATH=.
-          pytest -m "run_on_windows" .
+          pytest -m "not skip_on_windows" .
       - name: Run CLI tests
         shell: bash
         run: |

.github/workflows/test-localnet-tests.yml

@@ -51,5 +51,5 @@ jobs:
 
       - name: Test localnet dependent tests
         run: |
-           pytest -m require_localnet multiversx_sdk_cli/tests
+           pytest -m require_localnet .
           

multiversx_sdk_cli/tests/conftest.py

@@ -4,9 +4,7 @@
 # function executed right after test items collected but before test run
 def pytest_collection_modifyitems(config, items):
     if not config.getoption('-m'):
-        skip_me = pytest.mark.skip(reason="to run marked tests, you need to explicitly run them with -m")
+        skip_me = pytest.mark.skip(reason="require_localnet will only run if explicitly set to with -m")
         for item in items:
             if "require_localnet" in item.keywords:
                 item.add_marker(skip_me)
-            if "run_on_windows" in item.keywords:
-                item.add_marker(skip_me)

multiversx_sdk_cli/tests/test_cli_deps.py

@@ -41,13 +41,13 @@ def test_deps_check_testwallets():
     assert return_code == 0
 
 
-@pytest.mark.run_on_windows
+@pytest.mark.skip_on_windows
 def test_deps_install_all():
     return_code = main(["deps", "install", "all"])
     assert return_code == 0
 
 
-@pytest.mark.run_on_windows
+@pytest.mark.skip_on_windows
 def test_deps_check_all():
     return_code = main(["deps", "check", "all"])
     assert return_code == 0

pytest.ini

@@ -1,6 +1,6 @@
 [pytest]
 markers =
-    run_on_windows: marks tests as being skipped when running on windows (select with '-m "run_on_windows"')
+    skip_on_windows: marks tests as being skipped when running on windows (deselect with '-m "skip_on_windows"')
     only: only run a specific test (run using: pytest -m "only")
     require_localnet: marks tests that require a localnet (select with '-m "require_localnet"')