Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize provider #29

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Conversation

CiprianDraghici
Copy link
Contributor

No description provided.

@CiprianDraghici CiprianDraghici marked this pull request as ready for review September 6, 2024 13:17
@CiprianDraghici CiprianDraghici marked this pull request as draft September 6, 2024 13:18
@CiprianDraghici CiprianDraghici marked this pull request as ready for review September 6, 2024 14:07
@CiprianDraghici CiprianDraghici changed the title Standardize providers Standardize provider Sep 6, 2024
@CiprianDraghici CiprianDraghici changed the base branch from main to next September 6, 2024 14:44
src/hwProvider.spec.ts Outdated Show resolved Hide resolved
"buffer": "6.0.3",
"platform": "1.3.6"
},
"devDependencies": {
"@multiversx/sdk-core": ">= 13.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also accept earlier versions of v13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't because we are using things from sdk-core v13 (see signMessage)

@CiprianDraghici CiprianDraghici merged commit b7ddf4b into next Sep 6, 2024
@CiprianDraghici CiprianDraghici deleted the cd/feature/standardize-providers branch September 6, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants