Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ledger node hid transport #132

Closed
wants to merge 1 commit into from

Conversation

gfusee
Copy link

@gfusee gfusee commented Feb 21, 2022

Hi, I added ledger wallet compatibility when process is NodeJS

@andreibancioiu andreibancioiu changed the base branch from development to main March 10, 2022 08:44
@andreibancioiu
Copy link
Contributor

Hello @Quentus123, and thank you for the contribution!

At this moment, we only accept signed Git commits. Therefore, please follow: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Furthermore, please do not include the changes to package-lock.json in the PR. We will update the file separately.

@andreibancioiu
Copy link
Contributor

I am closing this PR (HW provider has moved). I am linking here your other PR: multiversx/mx-sdk-js-hw-provider#8 - that one is on hold, as well; we don't want to include those dependencies in the library - at least, not at this moment.

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants