added unit tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfaur09
reviewed
Oct 2, 2024
| expect(receivedEvents[0].timestamp).toEqual(123); | ||
| expect(axios.post).toHaveBeenCalledTimes(2); | ||
| }); | ||
|
|
There was a problem hiding this comment.
It would be useful to add a test that checks the behavior of the class when the call to Elasticsearch fails (eg using jest.MockRejectedValue to simulate a network error). This would cover cases of failure handling.
There was a problem hiding this comment.
Excelent! code coverage went to 98% :D
cfaur09
reviewed
Oct 2, 2024
| onEventsReceived: async (highestTimestamp, events) => {receivedEvents = events;}, | ||
| setLastProcessedTimestamp: async (timestamp: number) => {}, | ||
| }); | ||
|
|
There was a problem hiding this comment.
add expect for mockResponse just to check that the response from ElasticSearch is []
There was a problem hiding this comment.
No, since I won't receive anything because the es response doesn't contain any hit
bogdan-rosianu
changed the base branch from
SERVICES-2607-event-processor
to
main
cfaur09
approved these changes
Oct 2, 2024
tanghel
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.