Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #1059

Merged
merged 57 commits into from
Jan 29, 2024
Merged

Development #1059

merged 57 commits into from
Jan 29, 2024

Conversation

danielailie
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (f40a629) 42.87% compared to head (cdb73c4) 41.47%.
Report is 8 commits behind head on main.

Files Patch % Lines
src/modules/marketplaces/marketplaces.service.ts 66.66% 7 Missing and 8 partials ⚠️
...dules/proxy-deployer/proxy-deployer.abi.service.ts 59.37% 11 Missing and 2 partials ⚠️
...dules/nftCollections/collections-getter.service.ts 29.41% 9 Missing and 3 partials ⚠️
...-marketplace/disable-marketplace-events.service.ts 35.71% 5 Missing and 4 partials ⚠️
src/modules/analytics/elastic.indexer.service.ts 25.00% 3 Missing ⚠️
...rc/modules/nftCollections/models/Collection.dto.ts 0.00% 2 Missing and 1 partial ⚠️
...xy-deployer/models/requests/DeployMinterRequest.ts 50.00% 3 Missing ⚠️
src/common/persistence/persistence.service.ts 0.00% 2 Missing ⚠️
src/db/marketplaces/marketplaces.repository.ts 0.00% 2 Missing ⚠️
src/modules/assets/assets-getter.service.ts 50.00% 1 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   42.87%   41.47%   -1.41%     
==========================================
  Files         395      436      +41     
  Lines        8284     9300    +1016     
  Branches      952     1074     +122     
==========================================
+ Hits         3552     3857     +305     
- Misses       3830     4423     +593     
- Partials      902     1020     +118     
Flag Coverage Δ
unittests 41.47% <53.93%> (-1.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielailie danielailie merged commit d168492 into main Jan 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants