Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services 1944 add proxy deployer implementation #1058

Merged

Conversation

danielailie
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0b6a8d9) 41.38% compared to head (da2eee5) 41.45%.

Files Patch % Lines
...dules/proxy-deployer/proxy-deployer.abi.service.ts 59.37% 11 Missing and 2 partials ⚠️
...xy-deployer/models/requests/DeployMinterRequest.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1058      +/-   ##
===============================================
+ Coverage        41.38%   41.45%   +0.07%     
===============================================
  Files              434      436       +2     
  Lines             9257     9296      +39     
  Branches          1070     1073       +3     
===============================================
+ Hits              3831     3854      +23     
- Misses            4409     4423      +14     
- Partials          1017     1019       +2     
Flag Coverage Δ
unittests 41.45% <58.97%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielailie danielailie merged commit e9f57b0 into development Dec 14, 2023
3 checks passed
@danielailie danielailie deleted the SERVICES-1944-add-proxy-deployer-implementation branch December 14, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants