Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services 1895 fix critical dependencies #1051

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

danielailie
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (14e0660) 42.90% compared to head (79bc730) 42.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development    #1051   +/-   ##
============================================
  Coverage        42.90%   42.90%           
============================================
  Files              395      395           
  Lines             8272     8274    +2     
  Branches           952      952           
============================================
+ Hits              3549     3550    +1     
- Misses            3821     3822    +1     
  Partials           902      902           
Flag Coverage Δ
unittests 42.90% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/modules/s3/s3.service.ts 16.66% <33.33%> (+2.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielailie danielailie merged commit 92faa98 into development Oct 31, 2023
2 of 3 checks passed
@danielailie danielailie deleted the SERVICES-1895-fix-critical-dependencies branch October 31, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants