Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove whitelist collection #1048

Merged

Conversation

danielailie
Copy link
Collaborator

No description provided.

@danielailie danielailie self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (606bf50) 42.74% compared to head (fa4e938) 42.77%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1048      +/-   ##
===============================================
+ Coverage        42.74%   42.77%   +0.02%     
===============================================
  Files              395      395              
  Lines             8234     8254      +20     
  Branches           950      953       +3     
===============================================
+ Hits              3520     3531      +11     
- Misses            3814     3820       +6     
- Partials           900      903       +3     
Flag Coverage Δ
unittests 42.77% <54.16%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...equests/WhitelistCollectionOnMarketplaceRequest.ts 66.66% <66.66%> (ø)
src/modules/marketplaces/marketplaces.service.ts 81.73% <83.33%> (+<0.01%) ⬆️
src/common/persistence/persistence.service.ts 12.76% <0.00%> (-0.14%) ⬇️
...marketplaces/marketplace-collections.repository.ts 29.41% <16.66%> (-9.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielailie danielailie merged commit eef4e03 into development Oct 25, 2023
3 checks passed
@danielailie danielailie deleted the SERVICES-1887-add-remove-whitelist-collection branch October 25, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants