Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services 1856 fix assets query filter by collections #1031

Merged

Conversation

danielailie
Copy link
Collaborator

No description provided.

Base automatically changed from SERVICES-1841-extend-collection-analytics to development September 26, 2023 07:26
@danielailie danielailie force-pushed the SERVICES-1856-fix-assets-query-filter-by-collections branch from 63742fa to 7c83076 Compare September 26, 2023 08:32
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (f3266c1) 42.72% compared to head (7c83076) 42.67%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1031      +/-   ##
===============================================
- Coverage        42.72%   42.67%   -0.06%     
===============================================
  Files              392      392              
  Lines             8159     8172      +13     
  Branches           934      939       +5     
===============================================
+ Hits              3486     3487       +1     
- Misses            3788     3795       +7     
- Partials           885      890       +5     
Flag Coverage Δ
unittests 42.67% <10.52%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/modules/assets/assets-getter.service.ts 16.44% <ø> (ø)
src/modules/assets/assets-query.ts 21.73% <0.00%> (ø)
...dules/nftCollections/models/Collections-Filters.ts 75.00% <66.66%> (-1.93%) ⬇️
src/modules/nftCollections/collection-query.ts 4.00% <0.00%> (-0.77%) ⬇️
...dules/nftCollections/collections-getter.service.ts 10.00% <0.00%> (-0.21%) ⬇️
...c/modules/artists/smart-contract-artist.service.ts 21.42% <0.00%> (-2.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielailie danielailie merged commit 8aec7de into development Sep 26, 2023
1 of 3 checks passed
@danielailie danielailie deleted the SERVICES-1856-fix-assets-query-filter-by-collections branch September 26, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants