Merge pull request #1039 from multiversx/SERVICES-1882-upgrade-market…

…place-key-type

Update marketplace key and add contraints

src/db/marketplaces/marketplace.entity.ts

@@ -12,7 +12,7 @@ export class MarketplaceEntity extends BaseEntity {
   @Column({ length: 62 })
   name: string;
 
-  @Column({ length: 20, unique: true })
+  @Column({ length: 62, unique: true })
   key: string;
 
   @Column()

src/db/migrations/1696854100026-UpdateMarketplaceKeyLength.ts

@@ -0,0 +1,13 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+export class UpdateMarketplaceKeyLength1696854100026 implements MigrationInterface {
+  name = 'UpdateMarketplaceKeyLength1696854100026';
+
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`ALTER TABLE \`marketplaces\` MODIFY COLUMN \`key\` varchar(62) NOT NULL`);
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`ALTER TABLE \`marketplaces\` MODIFY COLUMN \`key\` varchar(20) NOT NULL`);
+  }
+}

src/modules/marketplaces/marketplaces.service.ts

@@ -13,6 +13,7 @@ import { WhitelistMarketplaceRequest } from './models/requests/WhitelistMarketpl
 import { UpdateMarketplaceRequest } from './models/requests/UpdateMarketplaceRequest';
 import { CacheEventsPublisherService } from '../rabbitmq/cache-invalidation/cache-invalidation-publisher/change-events-publisher.service';
 import { ChangedEvent, CacheEventTypeEnum } from '../rabbitmq/cache-invalidation/events/changed.event';
+import { mxConfig } from 'src/config';
 
 @Injectable()
 export class MarketplacesService {
@@ -189,7 +190,7 @@ export class MarketplacesService {
       const savedMarketplace = await this.persistenceService.saveMarketplace(
         new MarketplaceEntity({
           key: request.marketplaceKey,
-          address: request.marketplaceScAddress,
+          address: request.marketplaceScAddress ?? mxConfig.nftMarketplaceAddress,
           name: request.marketplaceName,
           url: request.marketplaceUrl,
           type: MarketplaceTypeEnum.Internal,

src/modules/marketplaces/models/UpdateMarketplaceArgs.ts

@@ -1,7 +1,11 @@
 import { Field, InputType } from '@nestjs/graphql';
+import { IsOptional, Matches, Max, MaxLength } from 'class-validator';
+import { ADDRESS_RGX, ADDRESS_ERROR } from 'src/utils/constants';
 
 @InputType()
 export class UpdateMarketplaceArgs {
+  @IsOptional()
+  @MaxLength(62)
   @Field({ description: 'This field will be shown on external apps like xSpothlight, xPortal!', nullable: true })
   marketplaceName: string;
 
@@ -12,5 +16,7 @@ export class UpdateMarketplaceArgs {
   marketplaceUrl: string;
 
   @Field({ description: 'Smart Contract Address, if not sent the default one will be used', nullable: true })
+  @IsOptional()
+  @Matches(RegExp(ADDRESS_RGX), { message: ADDRESS_ERROR })
   marketplaceScAddress: string;
 }

src/modules/marketplaces/models/WhitelistCollectionArgs.ts

@@ -1,5 +1,5 @@
 import { Field, InputType } from '@nestjs/graphql';
-import { Matches } from 'class-validator';
+import { Matches, MaxLength } from 'class-validator';
 import { COLLECTION_IDENTIFIER_ERROR, COLLECTION_IDENTIFIER_RGX } from 'src/utils/constants';
 
 @InputType()
@@ -10,6 +10,7 @@ export class WhitelistCollectionArgs {
   @Field()
   collection: string;
 
+  @MaxLength(62)
   @Field()
   marketplaceKey: string;
 }

src/modules/marketplaces/models/WhitelistMarketplaceArgs.ts

@@ -1,16 +1,21 @@
 import { Field, InputType } from '@nestjs/graphql';
+import { IsOptional, Matches, MaxLength } from 'class-validator';
+import { ADDRESS_RGX, ADDRESS_ERROR } from 'src/utils/constants';
 
 @InputType()
 export class WhitelistMarketplaceArgs {
   @Field({ description: 'This field will be shown on external apps like xSpothlight, xPortal!' })
   marketplaceName: string;
 
+  @MaxLength(62)
   @Field({ description: 'This should de a unique key, so choose wisely!' })
   marketplaceKey: string;
 
   @Field({ description: 'This will be used to redirect from external apps!' })
   marketplaceUrl: string;
 
   @Field({ description: 'Smart Contract Address, if not sent the default one will be used', nullable: true })
+  @IsOptional()
+  @Matches(RegExp(ADDRESS_RGX), { message: ADDRESS_ERROR })
   marketplaceScAddress: string;
 }