Fix get transaction endpoint #456
Conversation
miiu96
commented
Aug 5, 2024
miiu96
commented
- Fixed get transaction endpoint
# Conflicts: # process/transactionProcessor.go
process/transactionProcessor.go
Outdated
| return &data.ProcessStatusResponse{ | ||
| Status: string(transaction.TxStatusPending), | ||
| Status: string(transaction.TxStatusSuccess), |
There was a problem hiding this comment.
this is wrong. How we are going to return the pending status?
There was a problem hiding this comment.
reverted the changes
| for _, scr := range scrs { | ||
| sndShardID, err := tp.getShardByAddress(scr.SndAddr) | ||
| if err != nil { | ||
| log.Warn("cannot compute shard ID from sender address", |
There was a problem hiding this comment.
I think a continue statement should be added here, otherwise it will use 0 as sndShardID
| } | ||
|
|
||
| rcvShardID, err := tp.getShardByAddress(scr.RcvAddr) | ||
| if err != nil { |
miiu96
force-pushed
the
fix-transcation-endpoint
branch
from
2e0e5bb to
73edf0b
Compare
There was a problem hiding this comment.
Normal allin test: rc -> new-endpoint-scrs-by-tx-hash with proxy fix-transcation-endpoint #allin
--- Specific errors ---
block hash does not match 651
wrong nonce in block 304
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 263
Nr. of new ERRORS: 0
Nr. of new WARNS: 10
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
