Skip to content

Commit

Permalink
fixes after review 2
Browse files Browse the repository at this point in the history
  • Loading branch information
axenteoctavian committed Nov 22, 2024
1 parent 1559ae8 commit f7e8f78
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion factory/runType/interface.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package runType

// RunTypeComponentsCreator is the interface for the runTypeComponentsCreator
// RunTypeComponentsCreator is the interface for creating run type components
type RunTypeComponentsCreator interface {
Create() *runTypeComponents
IsInterfaceNil() bool
Expand Down
2 changes: 1 addition & 1 deletion factory/runType/runTypeComponentsHandler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func TestNewManagedRunTypeComponents(t *testing.T) {
t.Run("should error", func(t *testing.T) {
managedRunTypeComponents, err := NewManagedRunTypeComponents(nil)
require.ErrorIs(t, err, errNilRunTypeComponents)
require.True(t, managedRunTypeComponents.IsInterfaceNil())
require.Nil(t, managedRunTypeComponents)
})
t.Run("should work", func(t *testing.T) {
rtcf := NewRunTypeComponentsFactory()
Expand Down

0 comments on commit f7e8f78

Please sign in to comment.