Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sovereign] Epoch start trigger factory tests #6676

Open
wants to merge 5 commits into
base: MX-15415-remove-returned-errors-factories
Choose a base branch
from
Open

[sovereign] Epoch start trigger factory tests #6676

wants to merge 5 commits into from

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Dec 13, 2024 •
edited
Loading

Reasoning behind the pull request

  • Unit tests for epoch start trigger factories without cyclic imports.

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Dec 13, 2024
@mariusmihaic mariusmihaic marked this pull request as ready for review December 16, 2024 10:44
@mariusmihaic mariusmihaic mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axenteoctavian axenteoctavian axenteoctavian approved these changes

Assignees

@mariusmihaic mariusmihaic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusmihaic @axenteoctavian