Fix transaction/pool endpoint issues

[sstanculeanu]

Reasoning behind the pull request

• if hash is not explicitly provided, it is not returned in response
• when requesting with fields=*, senderShard and receiverShard are always 0

Proposed changes

• fix the fields

Testing procedure

• standard system test + add some cross shard txs in the pool. Check:
  • /transaction/pool?fields=* returns proper shards for sender and receiver.
  • /transaction/pool?by-sender="sender"&fields="*" returns proper shards
  • /transaction/pool?by-sender="sender"&fields=sender returns txHash as well(same for all combinations of fields)

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[sstanculeanu]

Run Tests:
mx-chain-testing-suite: main
mx-chain-simulator-go: main

[github-actions]

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

• mx-chain-go Commit Hash: 4c24359ab89654bee5b184d2506d31cd959165bf
• Current Branch: master
• mx-chain-go Target Branch: ``
• mx-chain-simulator-go Target Branch: main
• mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

• TIMESTAMP: 05122024-101352
• PYTEST_EXIT_CODE: 0
  🎉 MultiversX CI/CD Workflow Complete!

[github-actions]

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

• mx-chain-go Commit Hash: d744ac4e4f139f7c588777cf796ce5c263092ab7
• Current Branch: mx-16113_fix_transaction_pool_endpoint
• mx-chain-go Target Branch: rc/spica-patch-relayedv3
• mx-chain-simulator-go Target Branch: main
• mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

• TIMESTAMP: 05122024-101519
• PYTEST_EXIT_CODE: 0
  🎉 MultiversX CI/CD Workflow Complete!

[github-actions]

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

• mx-chain-go Commit Hash: 9ac1370cac952b953b920d5da4b71d7009bd9636
• Current Branch: mx-16113_fix_transaction_pool_endpoint
• mx-chain-go Target Branch: rc/spica-patch-relayedv3
• mx-chain-simulator-go Target Branch: main
• mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

• TIMESTAMP: 05122024-102156
• PYTEST_EXIT_CODE: 0
  🎉 MultiversX CI/CD Workflow Complete!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rc/spica-patch-relayedv3@5656a3e). Learn more about missing BASE report.

Additional details and impacted files

@@                     Coverage Diff                     @@
##             rc/spica-patch-relayedv3    #6651   +/-   ##
===========================================================
  Coverage                            ?   78.69%           
===========================================================
  Files                               ?      753           
  Lines                               ?    99299           
  Branches                            ?        0           
===========================================================
  Hits                                ?    78143           
  Misses                              ?    15885           
  Partials                            ?     5271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elvisboghiu]

System test:
Normal allin test: v1.8.4-dev-config-171a31edab -> mx-16113_fix_transaction_p-9ac1370cac
--- Specific errors ---
block hash does not match 1924
wrong nonce in block 762
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 280
Nr. of new ERRORS: 0
Nr. of new WARNS: 38
Nr. of PANICS: 0
Nodes with panic: []
/------/
--- System test go ---
All scenarios from system-test-go are OK!
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
ovh-p03-validator-28 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 5
ovh-p03-validator-10 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-18 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-16 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-34 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-35 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-21 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-32 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-11 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-1 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-31 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-26 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-30 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-15 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
ovh-p03-validator-20 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3
ovh-p03-validator-8 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
ovh-p03-validator-2 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
/------/