Optimize GH workflows #6487
Merged
Optimize GH workflows #6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Sep 23, 2024
.github/workflows/build_and_test.yml
Outdated
| @@ -9,7 +9,7 @@ jobs: | |||
| build: | |||
| strategy: | |||
| matrix: | |||
| runs-on: [ubuntu-latest, macos-13, macos-13-xlarge] | |||
| runs-on: [ubuntu-latest] | |||
There was a problem hiding this comment.
Separated workflow for running the tests on MacOS, as well.
andreibancioiu
commented
Sep 23, 2024
| @@ -0,0 +1,48 @@ | |||
| name: Build and smoke test (MacOS) | |||
There was a problem hiding this comment.
Separate workflow, for simplicity (creating a separate run-on matrix with respect to the trigger & target is quite complex).
andreibancioiu
commented
Sep 23, 2024
| build: | ||
| strategy: | ||
| matrix: | ||
| runs-on: [macos-latest] |
There was a problem hiding this comment.
Only for macos-latest. This is ARM64.
andreibancioiu
commented
Sep 23, 2024
| @@ -129,7 +129,7 @@ jobs: | |||
| zip -r -j ${ARCHIVE} ${BUILD_DIR} | |||
|
|
|||
| - name: Save artifacts | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
Necessary, due to:
Error: This request has been automatically failed because it uses a deprecated version of `actions/download-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
andreibancioiu
commented
Sep 23, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
| build: | |||
| strategy: | |||
| matrix: | |||
| runs-on: [ubuntu-latest, macos-13, macos-13-xlarge] | |||
| runs-on: [ubuntu-latest] | |||
There was a problem hiding this comment.
We weren't using the MacOS binaries as official build artifacts, anyway:
andreibancioiu
commented
Sep 23, 2024
| @@ -32,5 +30,5 @@ jobs: | |||
| context: . | |||
| file: ./docker/keygenerator/Dockerfile | |||
| platforms: linux/amd64,linux/arm64 | |||
| push: ${{ github.event_name != 'pull_request' }} | |||
| push: true | |||
There was a problem hiding this comment.
Fixed by Dani here:
andreibancioiu
commented
Sep 23, 2024
|
|
||
| on: | ||
| pull_request: | ||
| branches: [master] |
There was a problem hiding this comment.
Only for PRs against master.
bogdan-rosianu
approved these changes
Sep 23, 2024
danidrasovean
approved these changes
Sep 23, 2024
valentin-lup
approved these changes
Sep 24, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize running of GitHub workflows. Use
macos-latestinstead ofmacos-13-xlarge.