Merge pull request #4635 from ElrondNetwork/fixed-concurrency-issue-o…

…n-tx-simulator

Fixed transaction simulator data concurrency issue

process/txsimulator/txSimulator.go

@@ -2,6 +2,7 @@ package txsimulator
 
 import (
 	"encoding/hex"
+	"sync"
 
 	"github.com/ElrondNetwork/elrond-go-core/core"
 	"github.com/ElrondNetwork/elrond-go-core/core/check"
@@ -30,6 +31,7 @@ type ArgsTxSimulator struct {
 }
 
 type transactionSimulator struct {
+	mutOperation           sync.Mutex
 	txProcessor            TransactionProcessor
 	intermProcContainer    process.IntermediateProcessorContainer
 	addressPubKeyConverter core.PubkeyConverter
@@ -76,6 +78,9 @@ func NewTransactionSimulator(args ArgsTxSimulator) (*transactionSimulator, error
 
 // ProcessTx will process the transaction in a special environment, where state-writing is not allowed
 func (ts *transactionSimulator) ProcessTx(tx *transaction.Transaction) (*txSimData.SimulationResults, error) {
+	ts.mutOperation.Lock()
+	defer ts.mutOperation.Unlock()
+
 	txStatus := transaction.TxStatusPending
 	failReason := ""
 

process/txsimulator/txSimulator_test.go

@@ -3,7 +3,9 @@ package txsimulator
 import (
 	"encoding/hex"
 	"errors"
+	"sync"
 	"testing"
+	"time"
 
 	"github.com/ElrondNetwork/elrond-go-core/core"
 	"github.com/ElrondNetwork/elrond-go-core/data"
@@ -18,6 +20,7 @@ import (
 	"github.com/ElrondNetwork/elrond-go/testscommon"
 	"github.com/ElrondNetwork/elrond-go/testscommon/hashingMocks"
 	vmcommon "github.com/ElrondNetwork/elrond-vm-common"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -228,3 +231,34 @@ func getTxSimulatorArgs() ArgsTxSimulator {
 		Hasher:                    &hashingMocks.HasherMock{},
 	}
 }
+
+func TestTransactionSimulator_ProcessTxConcurrentCalls(t *testing.T) {
+	t.Parallel()
+
+	numTransactionProcessorCalls := 0
+	args := getTxSimulatorArgs()
+	args.TransactionProcessor = &testscommon.TxProcessorStub{
+		ProcessTransactionCalled: func(transaction *transaction.Transaction) (vmcommon.ReturnCode, error) {
+			// deliberately not used a mutex here as to catch race conditions
+			numTransactionProcessorCalls++
+
+			return vmcommon.Ok, nil
+		},
+	}
+	txSimulator, _ := NewTransactionSimulator(args)
+	tx := &transaction.Transaction{Nonce: 37}
+
+	numCalls := 100
+	wg := sync.WaitGroup{}
+	wg.Add(numCalls)
+	for i := 0; i < numCalls; i++ {
+		go func(idx int) {
+			time.Sleep(time.Millisecond * 10)
+			_, _ = txSimulator.ProcessTx(tx)
+			wg.Done()
+		}(i)
+	}
+
+	wg.Wait()
+	assert.Equal(t, numCalls, numTransactionProcessorCalls)
+}