fixes after review

multiversx · Dec 16, 2024 · 893302e · 893302e
1 parent 9724125
commit 893302e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/consensus/spos/bls/v1/subroundBlock.go b/consensus/spos/bls/v1/subroundBlock.go
@@ -547,9 +547,9 @@ func (sr *subroundBlock) receivedBlockHeader(ctx context.Context, cnsDta *consen
 
 func headerHasProof(headerHandler data.HeaderHandler) bool {
 	if check.IfNil(headerHandler) {
-		return true
+		return false
 	}
-	return headerHandler.GetPreviousProof() != nil
+	return !check.IfNilReflect(headerHandler.GetPreviousProof())
 }
 
 func (sr *subroundBlock) processReceivedBlock(ctx context.Context, cnsDta *consensus.Message) bool {

diff --git a/integrationTests/consensus/consensusSigning_test.go b/integrationTests/consensus/consensusSigning_test.go
@@ -8,7 +8,6 @@ import (
 	"testing"
 	"time"
 
-	logger "github.com/multiversx/mx-chain-logger-go"
 	"github.com/stretchr/testify/assert"
 
 	"github.com/multiversx/mx-chain-go/integrationTests"
@@ -71,8 +70,6 @@ func TestConsensusWithInvalidSigners(t *testing.T) {
 		t.Skip("this is not a short test")
 	}
 
-	_ = logger.SetLogLevel("*:DEBUG")
-
 	numMetaNodes := uint32(4)
 	numNodes := uint32(4)
 	consensusSize := uint32(4)
@@ -107,7 +104,7 @@ func TestConsensusWithInvalidSigners(t *testing.T) {
 		go checkBlockProposedEveryRound(numCommBlock, nonceForRoundMap, mutex, chDone, t)
 
 		extraTime := uint64(2)
-		endTime := time.Duration(roundTime)*time.Duration(numCommBlock+extraTime)*time.Millisecond + 10*time.Minute
+		endTime := time.Duration(roundTime)*time.Duration(numCommBlock+extraTime)*time.Millisecond + time.Minute
 		select {
 		case <-chDone:
 		case <-time.After(endTime):