Bug fix delete by query #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstanculeanu
reviewed
Apr 9, 2024
| // Iterate over the map and find the write index | ||
| var writeIndex string | ||
| for index, details := range indexData { | ||
| if len(indexData) == 1 { |
There was a problem hiding this comment.
why not this if before the for loop and return 0, nil?
There was a problem hiding this comment.
because I don't know the key from the map
client/elasticClient.go
Outdated
|
|
||
| for _, indexAlias := range details.Aliases { | ||
| if indexAlias.IsWriteIndex { | ||
| writeIndex = index |
client/elasticClient.go
Outdated
| } | ||
| } | ||
| if writeIndex != "" { | ||
| break |
There was a problem hiding this comment.
return writeIndex, nil?
client/elasticClient.go
Outdated
| break | ||
| } | ||
| } | ||
| return writeIndex, nil |
There was a problem hiding this comment.
with the above suggestions, perhaps return some error here, meaning the index was not found
| "delegators" : { } | ||
| } | ||
| } | ||
| } |
| } | ||
| } | ||
| } | ||
| } |
bogdan-rosianu
previously approved these changes
Apr 9, 2024
bogdan-rosianu
approved these changes
Apr 9, 2024
sstanculeanu
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_by_queryoperation