-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added remove code leaf builin func name #267
base: feat/remove-code-leaf
Are you sure you want to change the base?
Conversation
@@ -68,6 +68,7 @@ type Throttler interface { | |||
type KeyValueHolder interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we target the branch towards a feat branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
// WithoutCodeLeaf is used for account with code, it specifies that the trie code leaf has been moved to storage, | ||
// it is enabled only after the activation of MigrateCodeLeafEnableEpoch flag | ||
WithoutCodeLeaf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all nodes with version "without code leaf" are assumed to be also with auto balance enabled right?
Just to confirm, it would not be possible to move from NotSpecified directly to WithoutCodeLeaf right?
If this is the case we should take care of the testing process to allow enough time (and actively do the first migration - auto balance) before this and ensure everything is migrated to auto balance before, or directly start with AutoBalanceEnabled active.
Also would this version change affect the logic for auto balancing since the version will be different but auto balancing will still need to be done? (I am asking here if there are checks in the code for the specific AutoBalanceEnabled version)
The base branch was changed.
No description provided.