V3.1 audit fixes

bridge-proxy/src/bridge-proxy.rs

@@ -8,8 +8,7 @@ use sc_proxies::esdt_safe_proxy;
 use transaction::{CallData, EthTransaction};
 const MIN_GAS_LIMIT_FOR_SC_CALL: u64 = 10_000_000;
 const MAX_GAS_LIMIT_FOR_SC_CALL: u64 = 249999999;
-const DEFAULT_GAS_LIMIT_FOR_REFUND_CALLBACK: u64 = 20_000_000; // 20 million
-const DELAY_BEFORE_OWNER_CAN_CANCEL_TRANSACTION: u64 = 300;
+const DEFAULT_GAS_LIMIT_FOR_REFUND_CALLBACK: u64 = 1_000_000; // 1 million
 
 #[multiversx_sc::contract]
 pub trait BridgeProxyContract:
@@ -67,8 +66,8 @@ pub trait BridgeProxyContract:
         } else {
             CallData::default()
         };
-
-        if call_data.endpoint.is_empty()
+        let non_empty_args = call_data.args.is_some();
+        if (call_data.endpoint.is_empty() && non_empty_args)
             || call_data.gas_limit < MIN_GAS_LIMIT_FOR_SC_CALL
             || call_data.gas_limit > MAX_GAS_LIMIT_FOR_SC_CALL
         {
@@ -103,39 +102,25 @@ pub trait BridgeProxyContract:
         tx_call.register_promise();
     }
 
-    // TODO: will activate endpoint in a future release
-    // #[endpoint(cancel)]
-    fn cancel(&self, tx_id: usize) {
-        let tx_start_round = self.ongoing_execution(tx_id).get();
-        let current_block_round = self.blockchain().get_block_round();
-        require!(
-            current_block_round - tx_start_round > DELAY_BEFORE_OWNER_CAN_CANCEL_TRANSACTION,
-            "Transaction can't be cancelled yet"
-        );
-
-        let tx = self.get_pending_transaction_by_id(tx_id);
-        let payment = self.payments(tx_id).get();
-        self.tx().to(tx.to).payment(payment).transfer();
-        self.cleanup_transaction(tx_id);
-    }
     #[promises_callback]
     fn execution_callback(&self, #[call_result] result: ManagedAsyncCallResult<()>, tx_id: usize) {
         if result.is_err() {
-            self.refund_transaction(tx_id);
+            self.add_pending_tx_to_refund(tx_id);
         }
-        self.cleanup_transaction(tx_id);
+        self.pending_transactions().remove(&tx_id);
     }
 
-    fn refund_transaction(&self, tx_id: usize) {
-        let tx = self.get_pending_transaction_by_id(tx_id);
+    #[endpoint(executeRefundTransaction)]
+    fn execute_refund_transaction(&self, tx_id: usize) {
+        let tx = self.get_refund_transaction_by_id(tx_id);
         let esdt_safe_contract_address = self.get_esdt_safe_address();
-
         let unwrapped_token = self.unwrap_token(&tx.token_id, tx_id);
         let batch_id = self.batch_id(tx_id).get();
+
         self.tx()
             .to(esdt_safe_contract_address)
             .typed(esdt_safe_proxy::EsdtSafeProxy)
-            .create_transaction(
+            .create_refund_transaction(
                 tx.from,
                 OptionalValue::Some(esdt_safe_proxy::RefundInfo {
                     address: tx.to,
@@ -149,6 +134,8 @@ pub trait BridgeProxyContract:
                 &unwrapped_token.amount,
             )
             .sync_call();
+
+        self.finish_refund(tx_id);
     }
 
     fn unwrap_token(&self, requested_token: &TokenIdentifier, tx_id: usize) -> EsdtTokenPayment {
@@ -184,13 +171,20 @@ pub trait BridgeProxyContract:
     }
 
     fn finish_execute_gracefully(&self, tx_id: usize) {
-        self.refund_transaction(tx_id);
-        self.cleanup_transaction(tx_id);
+        self.add_pending_tx_to_refund(tx_id);
+        self.pending_transactions().remove(&tx_id);
     }
 
-    fn cleanup_transaction(&self, tx_id: usize) {
-        self.pending_transactions().remove(&tx_id);
+    fn finish_refund(&self, tx_id: usize) {
         self.ongoing_execution(tx_id).clear();
+        self.payments(tx_id).clear();
+        self.batch_id(tx_id).clear();
+        self.refund_transactions().remove(&tx_id);
+    }
+
+    fn add_pending_tx_to_refund(&self, tx_id: usize) {
+        let tx = self.get_pending_transaction_by_id(tx_id);
+        self.refund_transactions().insert(tx_id, tx);
     }
 
     fn get_next_tx_id(&self) -> usize {
@@ -217,4 +211,22 @@ pub trait BridgeProxyContract:
         }
         transactions
     }
+
+    #[view(getRefundTransactionById)]
+    fn get_refund_transaction_by_id(&self, tx_id: usize) -> EthTransaction<Self::Api> {
+        let tx = self.refund_transactions().get(&tx_id);
+        require!(tx.is_some(), "Invalid tx id");
+        tx.unwrap()
+    }
+
+    #[view(getRefundTransactions)]
+    fn get_refund_transactions(
+        &self,
+    ) -> MultiValueEncoded<MultiValue2<usize, EthTransaction<Self::Api>>> {
+        let mut transactions = MultiValueEncoded::new();
+        for (tx_id, tx) in self.refund_transactions().iter() {
+            transactions.push(MultiValue2((tx_id, tx)));
+        }
+        transactions
+    }
 }

bridge-proxy/src/config.rs

@@ -4,17 +4,21 @@ use transaction::EthTransaction;
 
 #[multiversx_sc::module]
 pub trait ConfigModule {
-    #[storage_mapper("pending_transactions")]
+    #[storage_mapper("pendingTransactions")]
     fn pending_transactions(&self) -> MapMapper<usize, EthTransaction<Self::Api>>;
 
+    #[view(refundTransactions)]
+    #[storage_mapper("refundTransactions")]
+    fn refund_transactions(&self) -> MapMapper<usize, EthTransaction<Self::Api>>;
+
     #[storage_mapper("payments")]
     fn payments(&self, tx_id: usize) -> SingleValueMapper<EsdtTokenPayment<Self::Api>>;
 
-    #[storage_mapper("batch_id")]
+    #[storage_mapper("batchId")]
     fn batch_id(&self, tx_id: usize) -> SingleValueMapper<u64>;
 
     #[view(highestTxId)]
-    #[storage_mapper("highest_tx_id")]
+    #[storage_mapper("highestTxId")]
     fn highest_tx_id(&self) -> SingleValueMapper<usize>;
 
     #[storage_mapper("ongoingExecution")]