added more cs tests #1418
Merged
added more cs tests #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsx/mx-api-service into feat/chain-simulator-e2e
…rsx/mx-api-service into feat/chain-simulator-e2e
- Removed `beforeAll` hooks that called `ChainSimulatorUtils.waitForEpoch(2)` from multiple e2e test files: - This change simplifies the test setup and improves test execution time.
…seconds to ensure proper deployment of the PingPong smart contract.
- Implement tests for GET /tags, including validation of response structure, pagination, and search functionality. - Add tests for GET /tags/count to verify the count of tags. - Include tests for GET /tags/:tag to ensure correct tag details are returned. - Enhance overall test coverage for the tags feature in the chain simulator.
- Implement tests for GET /collections/:collection/nfts to validate NFT retrieval, pagination, and filtering by various parameters (search term, identifiers, tags, creator, etc.). - Add tests for GET /collections/:collection/nfts/count to verify NFT count based on different criteria.
- Moved the issuance of NFT collections to occur after funding the address and before issuing Meta-ESDT collections. - This change improves the logical flow of the test data preparation process.
…arison
- Changed balance assertions from numeric comparison (expect(account.balance).toStrictEqual(1)) to string comparison (expect(account.balance).toStrictEqual("1")) in multiple test cases.
- This ensures consistency in data type handling for balance values across the tests.
…seconds to allow for additional processing time during test data preparation.
… response validation, and enhance property checks
| } | ||
| }); | ||
|
|
||
| it('should return transactions for a collection of type NFT with a specific hashes', async () => { |
There was a problem hiding this comment.
with a specific hashes -> with specific hashes
| } | ||
| }); | ||
|
|
||
| it('should return transfers for a collection of type NFT with a specific hashes', async () => { |
There was a problem hiding this comment.
with specific hashes
bogdan-rosianu
approved these changes
Dec 16, 2024
danielailie
reviewed
Dec 16, 2024
| @@ -1545,4 +1528,461 @@ describe('Accounts e2e tests with chain simulator', () => { | |||
| expect(response.data).toStrictEqual(expectedCount); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
I would split this into shorter files.. they are to big to even look at them
danielailie
reviewed
Dec 16, 2024
| @@ -149,4 +130,1185 @@ describe('Collections e2e tests with chain simulator', () => { | |||
| expect(response.data.collection).toBe(collection[0]); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
I would split this into files based on the routes
danielailie
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Proposed Changes
How to test