internet radio: fix few things #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ds1-e
commented
Jun 14, 2024
ds1-e
commented
- Better naming for table with active radios
- Change event sources
- Save colors to variable
- Better naming - Change event sources - Save colors to variable
|
@srslyyyy Is it not a security concern the fact that player serials are being sent to every client for them to store in a table? |
He's planning to refactor it even more, but this is a good start. Btw, serial faking has gotten a definite fix over a month ago, yet the practise needs to change; it's not brand new btw, i pulled this popular resource from my server and only did a few tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.