Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spanish.lua #476

Merged
merged 2 commits into from
May 10, 2024
Merged

Update spanish.lua #476

merged 2 commits into from
May 10, 2024

Conversation

kxndrick0
Copy link
Contributor

  • Fix variables name
  • Finish lang

fix and finish spanish lang
@Nico8340
Copy link
Contributor

Nico8340 commented May 4, 2024

Follow up of #475

Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting seems good to me, do we have a native Spanish speaker who could review the translation?

Copy link
Member

@0xCiBeR 0xCiBeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations overall look good. cc @Lpsd / @Dutchman101 for code review

Copy link
Member

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

[gameplay]/hedit/client/gui/languages/spanish.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/spanish.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/spanish.lua Outdated Show resolved Hide resolved
[gameplay]/hedit/client/gui/languages/spanish.lua Outdated Show resolved Hide resolved
Lpsd
Lpsd previously requested changes May 9, 2024
Copy link
Member

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Called it too soon! I've left one comment to review before this can be merged.

Also please fix the lint failures

[gameplay]/hedit/client/gui/languages/spanish.lua Outdated Show resolved Hide resolved
Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@jlillis jlillis dismissed Lpsd’s stale review May 10, 2024 02:50

Requested changes made

@jlillis jlillis merged commit b74c239 into multitheftauto:master May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants