Allow disabling/enabling default reporting system (#501)

[admin]/admin/client/admin_client.lua

@@ -40,6 +40,7 @@ addEvent ( "aClientAdminChat", true )
 addEvent ( "aClientResourceStart", true )
 addEvent ( "aClientResourceStop", true )
 addEvent ( "aClientAdminMenu", true )
+addEvent ( "aClientReports", true )
 function aAdminResourceStart ()
 	addEventHandler ( "aClientAdminMenu", root, aClientAdminMenu )
 	local node = xmlLoadFile ( "conf\\weathers.xml" )

[admin]/admin/client/gui/admin_messages.lua

@@ -55,10 +55,11 @@ function aViewMessagesClose ( destroy )
 	end
 end
 
-function aMessagesSync ( action, data )
+function aMessagesSync ( action, data, isReportDisabled )
 	if ( action == "get" ) then
 		_messages = data
 		guiGridListClear ( aMessagesList )
+
 		for id=#data,1,-1 do
 			local message = data[id]
 			local row = guiGridListAddRow ( aMessagesList )
@@ -68,6 +69,7 @@ function aMessagesSync ( action, data )
 			guiGridListSetItemText ( aMessagesList, row, 3, message.time, false, false )
 			guiGridListSetItemText ( aMessagesList, row, 4, removeColorCoding(message.author), false, false )
 		end
+		guiSetText(aMessagesForm, (isReportDisabled ~= "true" and "View Messages (reports are disabled)" or "View Messages"))
 	end
 end
 

[admin]/admin/client/gui/admin_report.lua

@@ -13,6 +13,7 @@ local reportCategories
 local aSelectPlayer = nil
 
 function aReport ( )
+
 	if ( aReportForm == nil ) then
 		reportCategories = {}
 		for i,cat in ipairs( split( g_Prefs.reportCategories, string.byte(',') ) ) do
@@ -58,8 +59,7 @@ function aReport ( )
 	guiBringToFront ( aReportForm )
 	showCursor ( true )
 end
-addCommandHandler ( "report", aReport )
-
+addEventHandler( "aClientReports", root, aReport )
 
 function aReportClose ( )
 	if ( aReportForm ) then

[admin]/admin/meta.xml

@@ -18,6 +18,7 @@
   <script src="server/admin_ACL.lua" />
   <script src="server/admin_settings.lua" />
   <script src="server/admin_screenshot.lua" />
+  <script src="server/admin_report.lua" />
   <script src="server/http/admin_http.lua" />
   <script src="client/admin_clientprefs.lua" type="client" cache="false" />
   <script src="client/admin_client.lua" type="client" cache="false" />
@@ -115,7 +116,13 @@
 				4. double click on the resource name
 			 ***************************************************** -->
 
-		<setting name="*maxmsgs" value="55"
+    <setting name="*reportsEnabled" value="true"
+					friendlyname="Enable default reporting system"
+          accept="true,false"
+					desc="When enabled, players will be able to submit reports to admins via the /report command."
+				  />
+
+	  <setting name="*maxmsgs" value="55"
 					friendlyname="Max messages"
 					accept="1-1000"
 					desc="Maximum admin messages to keep."

[admin]/admin/server/admin_report.lua

@@ -0,0 +1,7 @@
+addCommandHandler("report", function( playerSource )
+    if ( get("reportsEnabled") ~= "false" ) then
+        triggerClientEvent( playerSource, "aClientReports", playerSource )
+    else
+         outputChatBox ( "Reports are not accepted currently.", playerSource, 255, 0, 0 )
+    end
+end, false, false)

[admin]/admin/server/admin_server.lua

@@ -1510,6 +1510,8 @@ function ( action, data )
 		return
 	end
 	if ( action == "new" ) then
+		--dont allow creating reports when reports are disabled
+		if ( get("reportsEnabled") ~= "true" ) then return end
 		local time = getRealTime()
 		local id = #aReports + 1
 		aReports[id] = {}
@@ -1545,7 +1547,7 @@ function ( action, data )
 	end
 	if ( hasObjectPermissionTo ( client or source, "general.adminpanel" ) ) then
 		if ( action == "get" ) then
-			triggerClientEvent ( source, "aMessage", source, "get", aReports )
+			triggerClientEvent ( source, "aMessage", source, "get", aReports, get("reportsEnabled") )
 		elseif ( action == "read" ) then
 			if ( aReports[data] ) then
 				aReports[data].read = true