Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Blake3's extendable output function #216

Merged
merged 4 commits into from
May 19, 2022
Merged

Use Blake3's extendable output function #216

merged 4 commits into from
May 19, 2022

Conversation

mriise
Copy link
Contributor

@mriise mriise commented May 18, 2022

fixes #213 where output was only limited to 32 bytes

@mriise mriise requested a review from vmx May 18, 2022 22:57
@mriise
Copy link
Contributor Author

mriise commented May 18, 2022

slowly getting towards #130 :^)

vmx
vmx reviewed May 19, 2022
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mriise! I've only minor comments.

tests/lib.rs Show resolved Hide resolved
src/hasher_impl.rs Outdated Show resolved Hide resolved
mriise added 2 commits May 19, 2022 09:08
@mriise
minor fixes
acff6f1 
- use expected result & rename new blake3 test
- use easier to read code for filling inner digest with blake3
@mriise
run cargo fmt
a9a2a71
@vmx
Copy link
Member

vmx commented May 19, 2022

@mriise thanks! You should be able to merge it yourself. I'd squash merge it.

@mriise mriise merged commit 3a3dacf into multiformats:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmx vmx vmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic on size being smaller than default
2 participants
@mriise @vmx