reserve 0x2f (ASCII /) as the *path* multicodec #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
That way, we can always tell if something is a path or something else. We may also be able to take advantage of this later to combine a few concepts and get rid of the "multiaddrs look like paths but are totally not" problem. However, we can think about that later. This PR just reserves the code so we don't run into problems later. * Remove the distinction between string/binary multiaddrs. Instead, the "string" will *also* be a valid binary multiaddr. * Define a new multipath spec to combine multiaddrs and other paths. Related to: multiformats/multiaddr#70
Stebalien
force-pushed
the
feat/reserve-slash
branch
from
098b11d to
56b1f8f
Compare
|
@lgierth rebased. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, we can always tell if something is a path or something else.
We may also be able to take advantage of this later to combine a few
concepts and get rid of the "multiaddrs look like paths but are totally not"
problem. However, we can think about that later. This PR just reserves the code
so we don't run into problems later.
will also be a valid binary multiaddr.
Related to: multiformats/multiaddr#70