-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SystemStart
and BootStart
start types
#113
Conversation
Would be great to document that these two new constants are used for drivers to avoid confusion with a regular See: https://learn.microsoft.com/en-us/windows/win32/api/winsvc/nf-winsvc-createservicea |
I've added more precise comments on them to avoid confusing with usermode service start types. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good change. This will be a breaking change since we add variants to a public enum. I think we should mark this enum as #[non_exhaustive]
to prevent that in the future.
@faern Thank you for the review. I've added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kkent030315)
src/service.rs
line 89 at r3 (raw file):
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] #[repr(u32)] #[non_exhaustive]
It looks like this actually is exhaustive now. So maybe this attribute is unnecessary.
Added
SystemStart
(SERVICE_SYSTEM_START
) andBootStart
(SERVICE_BOOT_START
) start types.This change has been tested locally.
This change is