Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the stat printing *pop* with colors and newlines #37

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

faern
Copy link
Member

@faern faern commented Nov 29, 2024

I got this feedback from a colleague. That it was hard to read the stats because it was printed juuust after all the errors. Hard to see where the errors stopped and the summary started.

I fixed this by doing two things:

  • Add a newline before the summary text, if any errors had been printed ahead of it
  • If stdout supports colors, use them! Prints the stats in green when there are no errors and red if there are errors.

@faern faern force-pushed the improve-stats-summary branch from e302026 to 4f35498 Compare November 29, 2024 15:43
@gregoire-mullvad
Copy link
Member

I tried this and it seems to break cargo run for me: it hangs just before printing the stats 🤔

@faern faern force-pushed the improve-stats-summary branch from 4f35498 to d59f07e Compare December 12, 2024 14:11
@faern faern merged commit 9a315d5 into main Dec 12, 2024
13 checks passed
@faern faern deleted the improve-stats-summary branch December 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants