W-17333982: fix for HTTP:TIMEOUT error #961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sf-himmatbir
reviewed
Dec 2, 2024
| @@ -262,7 +262,7 @@ private void doRequestWithRetry(HttpExtensionClient client, HttpRequesterConfig | |||
| } | |||
|
|
|||
| logger.error(getErrorMessage(httpRequest)); | |||
| HttpError error = exception instanceof TimeoutException ? TIMEOUT : CONNECTIVITY; | |||
| HttpError error = exception instanceof TimeoutException ? REQUEST_TIMEOUT : CONNECTIVITY; | |||
There was a problem hiding this comment.
As discussed, Currently we are throwing HTTP:Timeout in case of no response, after this change we will throw HTTP:REQUEST_TIMEOUT.
As per earlier implementation customers might be expecting HTTP:Timeout here so this might break few things on their side. It would suggest to keep it same.
For the scenario where status code is 408, we can try if HTTP:Timeout can be thrown there as well to make sure it is same everywhere.
If above is not possible then can go ahead with REQUEST_TIMEOUT at both places and need to update the documentation as well.
sf-himmatbir
approved these changes
Dec 3, 2024
eze210
requested changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attaching before and after images for the fix