Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-11633480 Fixing interface to return ListableTypeLoader #1049

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

W-11633480 Fixing interface to return ListableTypeLoader #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e60011
W-11633480 Fixing interface to return ListableTypeLoader
martincousido Oct 20, 2022
15d72e4
Using listable typeloader for all createTypeLoader methods
martincousido Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion api-changes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
},
{
"code": "java.method.addedToInterface",
"new": "method org.mule.metadata.api.TypeLoader org.mule.runtime.api.metadata.ExpressionLanguageMetadataService::createTypeLoader(java.lang.String, org.mule.metadata.api.model.MetadataFormat, java.util.Collection<org.mule.metadata.message.api.el.ModuleDefinition>)",
"new": "method org.mule.metadata.api.ListableTypeLoader org.mule.runtime.api.metadata.ExpressionLanguageMetadataService::createTypeLoader(java.lang.String, org.mule.metadata.api.model.MetadataFormat, java.util.Collection<org.mule.metadata.message.api.el.ModuleDefinition>)",
"package": "org.mule.runtime.api.metadata",
"classSimpleName": "ExpressionLanguageMetadataService",
"methodName": "createTypeLoader",
Expand Down Expand Up @@ -141,6 +141,18 @@
"methodName": "addType",
"elementKind": "method",
"justification": "Support resolving types coming from mule in DW transformations"
},
{
"code": "java.method.returnTypeChangedCovariantly",
"old": "method org.mule.metadata.api.TypeLoader org.mule.runtime.api.metadata.ExpressionLanguageMetadataService::createTypeLoader(java.lang.String, org.mule.metadata.api.model.MetadataFormat)",
"new": "method org.mule.metadata.api.ListableTypeLoader org.mule.runtime.api.metadata.ExpressionLanguageMetadataService::createTypeLoader(java.lang.String, org.mule.metadata.api.model.MetadataFormat)",
"oldType": "org.mule.metadata.api.TypeLoader",
"newType": "org.mule.metadata.api.ListableTypeLoader",
"package": "org.mule.runtime.api.metadata",
"classSimpleName": "ExpressionLanguageMetadataService",
"methodName": "createTypeLoader",
"elementKind": "method",
"justification": "Now DataWeave type loader can list all the types available on the script"
}
]
}
Expand Down
9 changes: 5 additions & 4 deletions src/main/java/org/mule/runtime/api/metadata/ExpressionLanguageMetadataService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/
package org.mule.runtime.api.metadata;

import org.mule.metadata.api.ListableTypeLoader;
import org.mule.metadata.api.TypeLoader;
import org.mule.metadata.api.model.MetadataFormat;
import org.mule.metadata.api.model.MetadataType;
Expand Down Expand Up @@ -129,9 +130,9 @@ public interface ExpressionLanguageMetadataService extends Service {
*
* @param content The script
* @param metadataFormat The format that will be used for the loaded types
* @return The type loader
* @return The listable type loader
*/
TypeLoader createTypeLoader(String content, MetadataFormat metadataFormat);
ListableTypeLoader createTypeLoader(String content, MetadataFormat metadataFormat);


/**
Expand All @@ -140,10 +141,10 @@ public interface ExpressionLanguageMetadataService extends Service {
* @param content The script
* @param metadataFormat The format that will be used for the loaded types
* @param modules Other modules available
* @return The type loader
* @return The listable type loader
* @since 1.5
*/
TypeLoader createTypeLoader(String content, MetadataFormat metadataFormat, Collection<ModuleDefinition> modules);
ListableTypeLoader createTypeLoader(String content, MetadataFormat metadataFormat, Collection<ModuleDefinition> modules);


/**
Expand Down