Ensure different Windows flavors build their own abseil library #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stanhu
changed the title
stanhu
force-pushed
the
sh-isolate-windows-ucrt-builds
branch
3 times, most recently
from
6a7154b to
d515c4b
Compare
Previously if you ran: ``` bundle exec rake gem:x64-mingw-ucrt bundle exec rake gem:x64-mingw32 ``` The latter would fail with undefined symbols: ``` linking shared-object re2.so /usr/bin/x86_64-w64-mingw32-ld: /tmp/re2/ports/x86_64-w64-mingw32/abseil/20230125.3/lib/libabsl_time_zone.a(time_zone_libc.cc.obj):time_zone_libc.cc:(.text+0x97): undefined reference to `__imp___timezone' /usr/bin/x86_64-w64-mingw32-ld: /tmp/re2/ports/x86_64-w64-mingw32/abseil/20230125.3/lib/libabsl_time_zone.a(time_zone_libc.cc.obj):time_zone_libc.cc:(.text+0xa8): undefined reference to `__imp___dstbias' /usr/bin/x86_64-w64-mingw32-ld: /tmp/re2/ports/x86_64-w64-mingw32/abseil/20230125.3/lib/libabsl_time_zone.a(time_zone_libc.cc.obj):time_zone_libc.cc:(.text+0xde): undefined reference to `__imp___tzname' collect2: error: ld returned 1 exit status make: *** [Makefile:262: re2.so] Error 1 ``` The `timezone`, `dstbias`, and `tzname` symbols come from the Microsoft Runtime library. This happened because the abseil C++ library would be installed for `x64-mingw-ucrt` and `x64-mingw32` in the same directory based on the `host` value (`x86_64-w64-mingw32`). As a result, if `x64-mingw-ucrt` were built first, then the abseil libraries will link against the Universal C Runtime (UCRT). When `rake gem:x64-mingw32` is attempted after `rake gem:x64-mingw-ucrt`, then it will fail to link those symbols because the abseil library in `ports/x86_64-w64-mingw32` directory expects UCRT to be used. To avoid this mess, append the `RbConfig::CONFIG['arch']` to the mini_portile recipe to ensure `x64-mingw-ucrt` and `x64-mingw32` builds use different library paths.
stanhu
force-pushed
the
sh-isolate-windows-ucrt-builds
branch
from
d515c4b to
71f3bd5
Compare
mudge
reviewed
Jul 28, 2023
ext/re2/extconf.rb
Outdated
| target_dir = File.join(PACKAGE_ROOT_DIR, "ports") | ||
| # Ensure x64-mingw-ucrt and x64-mingw32 use different library paths since the host | ||
| # is the same (x86_64-w64-mingw32). | ||
| target_dir = File.join(target_dir, target_arch) if windows? && !target_arch.empty? |
There was a problem hiding this comment.
Is it worth doing this for all builds rather than special casing it only for Windows? (I’m not sure what a sensible fallback value is if target_arch is nil or empty.)
There was a problem hiding this comment.
I originally had that, but I ran into an issue where the vendored libraries got moved from ports/archives to ports/<arch>/archives, so the Rakefile couldn't find the tarballs to include:
Lines 111 to 112 in 1379bd2
There was a problem hiding this comment.
We could do what Nokogiri does and have an --enable-cross-build flag to indicate whether cross-compiling is happening.
There was a problem hiding this comment.
Yeah, that's a much better solution: cbe6dc6. We already use --enable-cross-build in the Rakefile even though we didn't actually use it extconf.rb. 😄
Using this flag will enable us to keep the vendored libraries in `ports/archives` rather than `ports/<arch>/archives`.
|
@mudge Anything else I can do to get this merged? Would love to see 2.0 out the door: #78 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you ran:
The latter would fail with undefined symbols:
The
timezone,dstbias, andtznamesymbols come from the Microsoft Runtime library.This happened because the abseil C++ library would be installed for
x64-mingw-ucrtandx64-mingw32in the same directory based on thehostvalue (x86_64-w64-mingw32). As a result, ifx64-mingw-ucrtwere built first, then the abseil libraries will link against the Universal C Runtime (UCRT). Whenrake gem:x64-mingw32is attempted afterrake gem:x64-mingw-ucrt, then it will fail to link those symbols because the abseil library inports/x86_64-w64-mingw32directory expects UCRT to be used.To avoid this mess, append the
RbConfig::CONFIG['arch']to the mini_portile recipe to ensurex64-mingw-ucrtandx64-mingw32builds use different library paths.