Starts to adjust codepaths to simplify how mkchromecast operates, and to more clearly distinguish between distinct operating modes. #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anup In particular, we should be able to drop mkchromecast.pid and simplify or drop mkchromecast.tmp.
…e related issues - Doesn't run `atexit` from multiple places - Avoids redundant usage of `atexit` and `signal` - Renames `show_control` to `block_until_exit`, which clarifies that it's actually essentially the main loop of the parent process - Avoids useless recursive call from the 'a' handler - Shares the `KeyboardInterrupt` exception handler between the controls-enabled and controls-disabled codepaths
…once per interpreter process, as designed)
This will avoid the need for stacks of conditions, such as `if self.mkcc.youtube_url is None and self.mkcc.source_url is None:`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the single-time arg-parsing behavior as specified in #425, and is an important step towards continuing to simplify cascading logic as covered by #434