Refactors the video pipeline generation from video.py to pipeline_builder.py #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a 1-to-1 refactor. There was a lot of not-clearly-intentional
inconsistency in the original implementation which was not all carried over.
Among other changes:
veryfast
preset in some places, andultrafast
in others. Those presets are described athttps://trac.ffmpeg.org/wiki/Encode/H.264#a2.Chooseapresetandtune
The new implementation uses
veryfast
across the board.extremely confusing. This has been significantly normalized. I wouldn't be
surprised if this results in regressions, but we'll be better off fixing those
regressions in the new implementation rather than trying to figure out how/why
they worked in the old one.
input conditions than they were in the legacy implementation. This may cause
regressions in cases where ffmpeg was sensitive to the specific order of those
arguments in different conditions.
This refactor makes significant progress on all three subgoals of #434. Most
importantly, there is no longer any work done at import time when importing
video.py.