Update to the Ember 4.12 LTS blueprint #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to simply run `npx ember-cli-update` so the latest version is always installed.
This resolves all autofixable linting errors.
This tool adds linting ignore comments to all code that triggers errors, so we can fix those in the future without having to globally ignore certain rules.
lint-to-the-future doesn't seem to support adding ignore comments to the test templates, so we resolved those manually.
We don't have any .css files so stylelint throws an error without that flag.
Windvis
commented
Feb 20, 2024
| "ember-auto-import": "^1.12.0", | ||
| "ember-cli-babel": "^7.26.10", | ||
| "ember-cli-htmlbars": "^5.7.2", | ||
| "ember-auto-import": "^2.6.3", |
There was a problem hiding this comment.
This could be considered a breaking change, since the consuming app also needs to have ember-auto-import v2 installed. This is a requirement for v4, so only 3.x apps might still have ember-auto-import v1. I'm not sure what the support policy is here.
This was referenced Feb 20, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the 4.12 blueprints and does the minimum to make the linters not complain. The silenced linting errors can then be fixed in a future pr.