Patch invert if #55
Open
Patch invert if #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inverts if conditions and statements when line numbers are in the wrong order. The next statements have sometimes inferior line numbers than then statements, making it impossible to debug.
I didn't notice any issue with if/else statements. I noticed the issue only with if statements that return or throw.
As I negate the condition I try to avoid double negation.
Unit tests included.
NOTE; I have a slightly better version of LineNumberVisitor in the other PR with MinMaxLineNumberVisitor.
I deprecated LineNumberVisitor rather than duplicating MinMaxLineNumberVisitor here to avoid a merge conflict of duplicated classes. We can clean this up if we decide to merge this all together.