-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure updates #656
Conversation
0707e46
to
74a3a96
Compare
Use their latest releases and fix some violations and issues. # Conflicts: # .github/workflows/linting.yml # .github/workflows/testing.yml
74a3a96
to
e6ebbbc
Compare
e6ebbbc
to
0aed75e
Compare
012d5f7
to
15cdd8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
I think the only suggestion I would have would be to use the macos-15 runner because it's out of beta. I think I read in another thread/issue/discussion that your goal is to support macOS 14 so.
My review doesn't matter as you've already merged this but I wanted to show my appreciation with a review.
Thank you! My main goal was to bring everything back into a running state. Now that this has been achieved and more folks start collaborating, a normal reviewing workflow should certainly be established. I checked it yesterday, and the macOS 15 runner still says "Public Preview". We should probably support and test multiple versions once macOS 15 is available, though. |
No description provided.