-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial proxy implementation #1
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,2 @@ | |||
/proxy/out/ | |||
/proxy/.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this .gitignore working? I see .idea in the PR.
@@ -0,0 +1,29 @@ | |||
package com.trimlighthacking; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider com.knottysoftware.trimlight.proxy?
You should generally own the domain you use for your package name.
private final int fixedUnknown2; | ||
|
||
public BuiltInPatternSetRequest(byte[] buffer) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly fine, but PTAL? We should at least confirm whether .idea should be in there or not.
Initial implementation of a Trimlight Proxy Server with some packet analysis.