Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial proxy implementation #1

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

SpartacusFinch
Copy link
Collaborator

Initial implementation of a Trimlight Proxy Server with some packet analysis.

@@ -0,0 +1,2 @@
/proxy/out/
/proxy/.idea
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this .gitignore working? I see .idea in the PR.

@@ -0,0 +1,29 @@
package com.trimlighthacking;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider com.knottysoftware.trimlight.proxy?

You should generally own the domain you use for your package name.

private final int fixedUnknown2;

public BuiltInPatternSetRequest(byte[] buffer) {

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace?

Copy link
Owner

@msjarrett msjarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, but PTAL? We should at least confirm whether .idea should be in there or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants