Iframe support #55
Iframe support #55
Conversation
|
It's unfortunate that this project was abandoned. This is an important PR. |
|
Nearly 2 years later but I have an update. 😅 This is a huge improvement to the tool! Many thanks to @oneforwonder for the contribution and patience! I use Storybook on a daily basis myself, and I'm sure this change will help a ton of people. 👏 👏 👏 I am not a direct contributor on this repo, so I can't approve or merge this PR. However, I am the owner of the Chrome extension, so I can make those releases. I pulled the changes in this PR down locally, built a new version, and submitted it for publishing as version Assuming this update passes, v1.2 will have iframe support. I tested this by going to the storybook website and using the extension there. Attached is a screenshot. I am very sorry for neglecting this PR for so long. I've really fallen behind on my OSS projects. 😞 I hope this gets approved soon and is worth the wait.
|
|
It’s been published! |
|
Nice! Thanks. |
This PR adds the ability to inject Pesticide styles into iframes.
My particular motivation for this to allow Pesticide to work with the React component development environment Storybook that uses iframes to contain components. You can test this PR with any public Storybook site like this one.
Along the way, I moved the injection script from a line-by-line-concatenated string into a separate JS file where it can have proper indentation, syntax highlighting, etc. I believe this is much more maintainable, especially with the (slightly) increased complexity added by this PR.