Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangle and Circle DMA drawing functions added #660

Closed
wants to merge 2 commits into from

Conversation

drvkmr
Copy link
Contributor

@drvkmr drvkmr commented Jul 23, 2024

Was using them a lot in my sketches, so decided to implement them properly with DMA capabilities.

-fillRectDMA
-fillCircleDMA
-fillCircleHelperDMA
-fillTriangleDMA
-fillEllipseDMA (it's actually a line with thickness and rounded ends)
@Lukaswnd
Copy link
Contributor

Sorry, the code looks nice, but I have to say this:
I think these are GFX functions, they don't belong to the lowest level driver. They belong to the GFX_Lite or the Adafruit_GFX. Or any other gfx you build on top. I simply don't want the lowlevel library to be flooded with higher level GFX stuff, because where do you start and where do you end? what's next a star, pentagon...

But on the otherhand I see that it might be faster if this lib would implement it. The Fill Rect is remarkable faster that the ArduinoGFX version, because it can use hlineDMA

@mrcodetastic
Copy link
Owner

Thanks for this code @drvkmr. I am not keen on putting this into this library as it's focused on the hardware level only. However, I'll see if I can get it to work from the GFX_Lite library.

We can then perhaps start looking at other cool things that could be put into GFX_Lite as well if I can get this to work.

@drvkmr
Copy link
Contributor Author

drvkmr commented Jul 25, 2024

@Lukaswnd @mrcodetastic I understand, will close this PR and we can look at this later for the GFX_Lite library. Have been playing with it already and it looks great!

@drvkmr drvkmr closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants