don't fail if subprocess finished #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. the user exited `less` before all results were written...
example from joern _before_ this PR:
```
importCpg("/home/mp/tmp/cpgtesting/linux-kernel/linux6-drivers-scsi.fg")
cpg.method.name.browse
Exception in thread "less stdin thread" java.io.IOException: Broken pipe
at java.base/java.io.FileOutputStream.writeBytes(Native Method)
at java.base/java.io.FileOutputStream.write(FileOutputStream.java:349)
at java.base/java.io.BufferedOutputStream.write(BufferedOutputStream.java:123)
at java.base/sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:234)
at java.base/sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:304)
at java.base/sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:282)
at java.base/sun.nio.cs.StreamEncoder.write(StreamEncoder.java:132)
at java.base/java.io.OutputStreamWriter.write(OutputStreamWriter.java:205)
at java.base/java.io.BufferedWriter.flushBuffer(BufferedWriter.java:120)
at java.base/java.io.BufferedWriter.write(BufferedWriter.java:233)
at replpp.Operators$$anon$1.processInput$$anonfun$1(Operators.scala:140)
at java.base/java.lang.Thread.run(Thread.java:840)
```
This PR silences this issue.
maltek
approved these changes
Jul 23, 2024
| } | ||
| } | ||
| // flush stdin, but ignore errors | ||
| try {stdin.flush()} catch { case t: Throwable => /*ignore*/ } |
There was a problem hiding this comment.
should be safe to just drop this line - closing already implies pushing out all unwritten data.
There was a problem hiding this comment.
that's what I thought too, but unfortunately that's not the case.
check out the two runs above, I only added this line after seeing the red tests, which were caused by non-flushiness
|
I agree re NonFatal though, just changed that part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. the user exited
lessbefore all results were written...example from joern before this PR:
This PR silences this issue.