Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/update setting of integration attributes #9

Closed
wants to merge 5 commits into from
Closed

Hotfix/update setting of integration attributes #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
248ae4e
Update to properly set integration attribute
SbDove Dec 2, 2024
a01baa6
Merge branch 'main' into hotfix/update-setting-of-integration-attributes
SbDove Dec 2, 2024
9b3ef54
Revert to using const
SbDove Dec 2, 2024
3736889
Revert build files
SbDove Dec 2, 2024
7548b25
Revert to testing partnerId
SbDove Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/ID5Kit.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,7 +1037,7 @@ Common.prototype.logId5Id = function (id5Id) {
id5IdType: this.id5IdType,
};

window.mParticle.setIntegrationAttributes(this.moduleId, integrationAttributes);
window.mParticle.setIntegrationAttribute(this.moduleId, integrationAttributes);
};

Common.prototype.buildPartnerData = function (mParticleUser) {
Expand Down
2 changes: 1 addition & 1 deletion dist/ID5Kit.iife.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ var ID5Kit = (function (exports) {
id5IdType: this.id5IdType,
};

window.mParticle.setIntegrationAttributes(this.moduleId, integrationAttributes);
window.mParticle.setIntegrationAttribute(this.moduleId, integrationAttributes);
};

Common.prototype.buildPartnerData = function (mParticleUser) {
Expand Down
2 changes: 1 addition & 1 deletion src/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Common.prototype.logId5Id = function (id5Id) {
id5IdType: this.id5IdType,
};

window.mParticle.setIntegrationAttributes(this.moduleId, integrationAttributes);
window.mParticle.setIntegrationAttribute(this.moduleId, integrationAttributes);
};

Common.prototype.buildPartnerData = function (mParticleUser) {
Expand Down
3 changes: 2 additions & 1 deletion test/end-to-end-testapp/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var SDKsettings = {
partnerId: 1234
partnerId: 1234,
id5IdType: "Other"
/* fill in SDKsettings with any particular settings or options your sdk requires in order to
initialize, this may be apiKey, projectId, primaryCustomerType, etc. These are passed
into the src/initialization.js file as the
Expand Down
2 changes: 1 addition & 1 deletion test/src/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('ID5 Forwarder', function () {
}
};

mParticle.setIntegrationAttributes = function(id, attributes) {
mParticle.setIntegrationAttribute = function(id, attributes) {
integrationAttributes[id] = attributes;
}

Expand Down
Loading