Update syntax for clarity

mparticle-integrations · Nov 6, 2024 · b243923 · b243923
1 parent 98f2486
commit b243923
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/src/common.js b/src/common.js
@@ -6,9 +6,15 @@ Common.prototype.exampleMethod = function () {
 }
 
 Common.prototype.logId5Id = function (id5Id) {
-    var integrationAttributes = {};
-    integrationAttributes['encryptedId5Id'] = id5Id;
-    integrationAttributes['id5IdType'] = this.id5IdType;
+    if (id5Id == undefined) {
+        return;
+    }
+
+    var integrationAttributes = {
+        encryptedId5Id: id5Id,
+        id5IdType: this.id5IdType,
+    };
+
     window.mParticle.setIntegrationAttributes(this.moduleId, integrationAttributes);
 };
 

diff --git a/test/src/tests.js b/test/src/tests.js
@@ -22,8 +22,10 @@ describe('ID5 Forwarder', function () {
     // -------------------DO NOT EDIT ANYTHING ABOVE THIS LINE-----------------------
     // -------------------START EDITING BELOW:-----------------------
     // -------------------mParticle stubs - Add any additional stubbing to our methods as needed-----------------------
+    var Id5ModuleId = 248;
     var userAttributes = {};
     var integrationAttributes = {};
+
     mParticle.Identity = {
         getCurrentUser: function() {
             return {
@@ -190,7 +192,7 @@ describe('ID5 Forwarder', function () {
                 },
             };
             var pd = mParticle.forwarder.common.buildPartnerData(user)
-            debugger;
+
             expect(pd).to.be.null;
             done();
         });
@@ -322,10 +324,18 @@ describe('ID5 Forwarder', function () {
 
         it ('should log an integration attribute when logId5Id is called', function(done) {
             mParticle.forwarder.common.logId5Id("testId");
-            var attributes = integrationAttributes[248];
+            var attributes = integrationAttributes[Id5ModuleId];
             attributes['encryptedId5Id'].should.equal('testId');
             attributes['id5IdType'].should.equal('other_5')
             done();
         })
+
+        it ('should not log an integration attribute when logId5Id is called with a null or undefined value', function(done) {
+            mParticle.forwarder.common.logId5Id(null);
+            integrationAttributes[248].should.be.null;
+            mParticle.forwarder.common.logId5Id(undefined);
+            integrationAttributes[248].should.be.null;
+            done();
+        })
     })
 });