feat: initialization rework #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbDove
changed the base branch from
main
to
feat/SQDSDKS-6538-update-testrunners
alexs-mparticle
approved these changes
Jun 26, 2024
alexs-mparticle
changed the base branch from
feat/SQDSDKS-6538-update-testrunners
to
development
SbDove
force-pushed
the
feat/initializaiton-rework
branch
from
537925e to
6196b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{provide a thorough description of the changes}
Updates the initialization of the Heap SDK into a separate function and updates the unit tests to successfully run.
Testing Plan
{explain how this has been tested, and what additional testing should be done}
This has been tested locally via testEndToEnd.
Master Issue
Closes https://mparticle-eng.atlassian.net/browse/SQDPB-3968