Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial Release #5

Merged
merged 12 commits into from
Jun 18, 2024
Merged

feat: Initial Release #5

merged 12 commits into from
Jun 18, 2024

Conversation

SbDove
Copy link
Collaborator

@SbDove SbDove commented Jun 18, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • {provide a thorough description of the changes}

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

SbDove and others added 10 commits June 10, 2024 12:50
* Initialize the Heap SDK and add to unit tests

---------

Co-authored-by: Alex S <[email protected]>
Co-authored-by: Steve Hwang <[email protected]>
Add first draft of Github workflows

Update workflow to proper test invocation

Update to v4

Upload package-lock

Update package-lock

Remove dist from github upload
Add first draft of Github workflows

Update workflow to proper test invocation

Update to v4

Upload package-lock

Update package-lock

Remove dist from github upload

feat: initialization of Heap SDK (#1)

* Initialize the Heap SDK and add to unit tests

---------

Co-authored-by: Alex S <[email protected]>
Co-authored-by: Steve Hwang <[email protected]>

Update Readme, add license, and contributing
@SbDove SbDove requested a review from alexs-mparticle June 18, 2024 19:10
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved

1. Fork this repo and `cd` into it locally on your computer.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SbDove Are you planning on adding this back with specific instructions later?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexs-mparticle - I certainly can, if they are needed. I see that we have explicit usage instructions in some repos such as GA4 and not in others such as GTM. Let me know and I can add more explicit instructions after we have more of the kit features launched.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me.

@SbDove SbDove merged commit 7e1d949 into main Jun 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants