fix: send default and update consent payloads on kit init #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
approved these changes
Oct 4, 2024
rmi22186
reviewed
Oct 8, 2024
packages/GA4Client/test/src/tests.js
Outdated
| window.dataLayer[6][0].should.equal('consent'); | ||
| window.dataLayer[6][1].should.equal('update'); | ||
| window.dataLayer[6][2].should.deepEqual(expectedDataLayerFinal[2]); | ||
| // Consent Update is index 5 |
There was a problem hiding this comment.
I believe its the 'Test Event' event, will console.log it, confirm and add it for reference
There was a problem hiding this comment.
oh wait nvm, its the initial update since the new workflow doesn't merge defaults and fire two consent payloads on init (one default one update)
rmi22186
reviewed
Oct 8, 2024
rmi22186
approved these changes
Oct 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [1.4.5](v1.4.4...v1.4.5) (2024-10-09) ### Bug Fixes * send default and update consent payloads on kit init ([#61](#61)) ([ec0bf79](ec0bf79))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Master Issue
Closes https://mparticle-eng.atlassian.net/browse/SQDSDKS-6815