fix:add check and replace warn instead of error for setCustomNameStan… #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
requested changes
Nov 20, 2023
packages/GA4Client/src/common.js
Outdated
| 'Error calling setCustomNameStandardization callback. Check your callback. Data will still be sent without user-defined standardization. See our docs for proper use - https://docs.mparticle.com/integrations/google-analytics-4/event/', | ||
| e | ||
| ); | ||
| if (window.GoogleAnalytics4Kit.setCustomNameStandardization(name)) { |
There was a problem hiding this comment.
If you're checking if setCustomNameStandardization exists, you might be better off using hasOwnProperty instead of calling the function directly.
If the function does not exist, calling the function would throw an error before the try/catch block. Also, if the function does exist, you're essentially calling it twice.
Suggested change
| if (window.GoogleAnalytics4Kit.setCustomNameStandardization(name)) { | |
| if (window.GoogleAnalytics4Kit.hasOwnProperty(setCustomNameStandardization)) { |
There was a problem hiding this comment.
@alexs-mparticle thanks for correction, applying the change
rmi22186
requested changes
Nov 20, 2023
packages/GA4Client/src/common.js
Outdated
| 'Error calling setCustomNameStandardization callback. Check your callback. Data will still be sent without user-defined standardization. See our docs for proper use - https://docs.mparticle.com/integrations/google-analytics-4/event/', | ||
| e | ||
| ); | ||
| if (window.GoogleAnalytics4Kit.hasOwnProperty(setCustomNameStandardization)) { |
There was a problem hiding this comment.
setCustomNameStandardization is not a variable, but rather, a string
Suggested change
| if (window.GoogleAnalytics4Kit.hasOwnProperty(setCustomNameStandardization)) { | |
| if (window.GoogleAnalytics4Kit.hasOwnProperty('setCustomNameStandardization')) { |
|
It looks like this test already does not have the callback when testing standardization, so the fact that this test doesn't break is sufficient and no additional test needs to be added. |
rmi22186
approved these changes
Nov 20, 2023
samdozor
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dardization
Summary
#54
Testing Plan
Added code to local overrides and tested the warn instead error and then added the if statement to check the callback.
Master Issue
Closes https://go.mparticle.com/work/REPLACE