-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Google EU Consent #51
Conversation
@@ -12,7 +12,9 @@ | |||
"scripts": { | |||
"build": "rollup --config rollup.config.js", | |||
"watch": "rollup --config rollup.config.js -w", | |||
"test": "node test/boilerplate/test-karma.js" | |||
"test": "node test/boilerplate/test-karma.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is out of scope, but we should add a follow up item to remove the boilerplate tests in favor of the most recent test framework. The boilerplate framework is known to fail silently at times and I would rather we brought Braze in line with the rest of the kits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add this work item to the rollup.test.config.js since I can't add comments to a json file.
lgtm overall, just added a couple of suggestions, please ignore if I'm wrong |
Co-authored-by: Alex S <[email protected]>
Instructions
development
Summary
Implement Braze's EU consent for Google.
The kit should set consent on a Braze user as a custom attribute:
When consent mapping is not configured in the UI, OR a customer does not have consent on it, do not attempt to set consent on the Braze user.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)