fix: Allow any userIdentificationType to be used when initializing kit #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
force-pushed
the
fix/SQDSDKS-6345-identify-with-any-user-type
branch
from
2f551bf to
dd4c425
Compare
alexs-mparticle
requested changes
May 3, 2024
| @@ -792,10 +794,13 @@ var constructor = function () { | |||
| braze.addSdkMetadata(['mp']); | |||
| primeBrazeWebPush(); | |||
|
|
|||
| if (forwarderSettings.userIdentificationType === 'MPID' && mParticle.Identity != null && mParticle.Identity.getCurrentUser().getMPID() != null) { | |||
There was a problem hiding this comment.
If we're no longer referencing forwarderSettings, we should remove it from the function parameters.
There was a problem hiding this comment.
It is still being passed to openSession at the bottom of this function
There was a problem hiding this comment.
Ooof. Missed that.
Co-authored-by: Alex S <[email protected]>
alexs-mparticle
approved these changes
May 3, 2024
| @@ -792,10 +794,13 @@ var constructor = function () { | |||
| braze.addSdkMetadata(['mp']); | |||
| primeBrazeWebPush(); | |||
|
|
|||
| if (forwarderSettings.userIdentificationType === 'MPID' && mParticle.Identity != null && mParticle.Identity.getCurrentUser().getMPID() != null) { | |||
There was a problem hiding this comment.
Ooof. Missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
development- Since this is Braze and there is a v3 and a v4, this does not apply as we need to manually releaseSummary
Previously we allowed a user to be identified on initialization only if they chose
MPIDas theiruserIdentificationType. This prevents customers from being able to use kit forwarding rules in Braze if they have any otheruserIdentificationTypepicked. Removing this constraint fixes that.Testing Plan
Added a test setting email to be the
userIdentificationTypeReference Issue (For mParticle employees only. Ignore if you are an outside contributor)